a3d065dd8d* fix(release): repair package repo publish
Arch repo metadata and R2 uploads need to be reproducible from CI, with retry hardening for transient Cloudflare failures.
* fix(daemon): stop shutdown log storm
Init waiter must treat ShuttingDown as terminal so daemon shutdown tests do not flood Meson logs while the daemon is stopping.
* refactor(cli): delegate serve to MCP binary
Keep yams serve UX while removing MCP server linkage from yams-cli. The standalone MCP binary owns stdio serving and exits on stdin EOF.
* refactor(cli): move daemon path helpers
Keep CLI path resolution out of YamsDaemon so later link cuts can separate CLI and daemon internals. Full yams_daemon removal still needs a socket-only daemon-client split.
* refactor(daemon): split embedded client
* perf(search): add lean-guided benchmark gates
Add Lean topology/search models, ingestion ablation docs, and focused regression tests for topology and compression threshold behavior.
Extract search observability, keep benchmark-only ablation controls, and make retrieval quality benchmarks default to Simeon while preserving explicit ONNX opt-in.
* refactor(config): move daemon policies
* refactor(daemon): extract plugin runtime
* refactor(daemon): untangle service coordinators
Untangle CLI/MCP from daemon service coordinators and the daemon static lib.
- MetadataRepository uses a daemon-neutral tree-diff callback. The
GraphComponent wrapper moves to src/daemon/components/metadata_graph_bridge.cpp,
owned by the daemon library.
- WriteCoordinator moves to a dedicated build-only yams_write_coordinator
static lib. Drop ResourceGovernor coupling inside the writer loop; batch
sizing still respects config.maxBatchSize.
- AppContext gains enqueuePostIngest callback. ServiceManager wires it to
its own enqueuePostIngest; app services no longer call ServiceManager
directly.
- Embedding repair uses BulkIngestLease/BeginBulkIngestCallback instead of
concrete VectorIndexCoordinator::BulkScope. Daemon dispatchers provide a
lease factory backed by the real coordinator.
- CLI daemon_command uses config helpers instead of YamsDaemon::getXDGRuntimeDir.
- Remove explicit dependency('yams_daemon') from src/cli and tools/yams-mcp.
- Declare missing yams_extraction/yams_ingest deps on yams_app_services so
app services link cleanly without daemon.
Validated:
meson compile -C build/release -j4 yams-daemon yams-cli yams-mcp-server
ninja -C build/release -t commands tools/yams-cli/yams-cli tools/yams-mcp/yams-mcp-server | grep -c libyams_daemon.a -> 0
yams-cli --version, yams-mcp-server init, yams serve --help smoke tests
Size drop on macOS release: yams-cli 41M -> 32M, yams-mcp-server 37M -> 22M.
* fix(cli): keep stdin add local fallback
No embedded daemon now. When yams add - buffers stdin and daemon IPC is missing, store via local app services instead of failing socket_missing.
Validated:
meson compile -C build/debug -j4 yams-cli catch2_cli_commands
MESON_BUILD_ROOT=/Users/trevon/work/tools/yams/build/debug build/debug/tests/catch2_cli_commands 'AddCommand - reads from piped stdin and stores content'
MESON_BUILD_ROOT=/Users/trevon/work/tools/yams/build/debug build/debug/tests/catch2_cli_commands
meson compile -C build/release -j4 yams-cli yams-mcp-server
meson compile -C build/asan-api -j2 yams-cli catch2_cli_commands
MESON_BUILD_ROOT=/Users/trevon/work/tools/yams/build/asan-api ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 build/asan-api/tests/catch2_cli_commands 'AddCommand - reads from piped stdin and stores content'
ninja -C build/release -t commands tools/yams-cli/yams-cli tools/yams-mcp/yams-mcp-server | grep libyams_daemon.a -> no output
* feat(bench): add xplan multi-arm experiment harness
Unified plan runner, ablation axes, REPORT/ablation docs, and
KPI snapshot so optimization loops stop living in shell matrices.
* feat(formal): expand topology/search Lean contracts
Boundary models for search provenance, construction gates,
and cluster/route objectives so Lean guides correctness while
xplan ranks performance levers.
* feat(search,topology): construction purity + graph expansion path
Raise topology build defaults (min edge 0.25, max component 64) and
split oversized CC pieces so hybrid assist is quality-positive on
scifact. Add GraphNeighbors expansion with medoid-anchor fallback,
structured helpers instead of nested session logic, and BEIR-default
xplan plans. Search engine extraction (fanout/classic pipeline) rides
along as the integration surface for routing.
* feat(topology): add KMeans engine and SGC identity contracts
Register kmeans in the factory with deterministic spherical k-means
over embeddings, and enforce SGC document-identity invariants in
debug builds with matching unit coverage.
* feat(daemon): topology readiness gates and selectable reranker
Drive topologyReady from published epoch/freshness/rebuild/dirty
ingest state (not just KG drain), surface those fields in search
stats, and wire onnx|simeon|auto|none cross-reranker selection.
* chore(search): drop meta_path tuner knobs
Meta-path routing is gone; remove dead TunedParams fields and the
ConfigResolver test for [search.meta_path].
* feat(bench): add topology_purity_validate plan
Repeats=3 validation matrix for construction-purity winners vs
topo_off so MRR deltas can clear run-to-run noise.
* chore: format add_command and config include order
Mechanical clang-format / include reorder only; no behavior change.
* feat(bench): decision-grade xplan loop for search engine
Document search-engine measurement in AGENTS; harden xplan with
repeats=3 plans, quality×latency primaries, mechanism metrics from
debug.jsonl, multi-rep log promotion, and archive superseded topology
plans.
* feat(graph): denser product semantic_neighbor topK
Raise default YAMS_GRAPH_SEMANTIC_TOPK fallback from 4 to 8 so product
graphs leave fewer degree-0 docs for GraphNeighbors expansion.
* feat(search): extract topology assist and cross-rerank seams
Pull topology assist into search_topology_stage (seed merge, skip
reasons, optional vector seed probe default 0). Extract cross_rerank
compute from search_engine. Wire probe via typed config/ConfigResolver.
* feat(bench): product-path search engine ablation plans
Add topology-off component, vector-weight, and tiered-execution xplan
plans (repeats=3) and wire them into the AGENTS measurement loop table.
* fix(ci): repair pre-push fallbacks
* feat(bench): lock-free mid-run builds + multi-corpus gates
xplan skips meson rebuild when the quality binary exists (flock +
YAMS_BENCH_FORCE_BUILD override) to stop multi-arm link races. Add
graph_vector weight and nfcorpus transfer-gate plans; document in AGENTS.
* fix(daemon): keep SearchEngine alive via shared_ptr cache
getCachedEngine previously published a raw pointer that metrics polling
used through rebuild, racing destructor of SearchEngine::Impl (TSAN).
Store and return a shared_ptr snapshot so diagnostic readers pin the
engine for the duration of getConfig/health checks.
Also adds the cautious vectorWeight 0.30→0.20 multi-corpus xplan plan.
* feat(search): route vectors through cached topology
Build and reuse validated topology snapshots, rank routed members by query similarity, and narrow the vector leg to the accepted document set with explicit work diagnostics.
Remove the retired HDBSCAN engine and vendor dependency, preserve typed topology policy through search tuning, and cover the runtime/configuration contracts.
* feat(bench): consolidate search decision plans
Enforce deterministic experiment identity and declared baselines, expose routed/global vector work metrics, and register the focused benchmark contracts.
Promote the compact repeats=3 routing-budget gate, archive superseded topology mechanism screens, and add multi-corpus product calibration plans.
* feat(search): refine topology vector routing
* fix(search): propagate daemon readiness
* feat(bench): measure generalized memory health
* fix(cli): honor in-process fallbacks
* ci: harden smolvm debug builds
* perf(search): route topology through filtered ANN
* feat(bench): measure read-write pressure
* perf(metadata): index symbol lookups on read pool
* fix(daemon): isolate startup reads and maintenance
* feat(bench): replay isolated generalized corpora
* feat(search): add evidence routing pipeline
Replace the blocking smolvm pre-push path with host ASan/TSan validation, harden sanitizer-sensitive smoke tests, and add recovery cleanup for malformed SQLite WAL sidecars.
* refactor(search): unify topology evidence path
Remove classic and sidecar fusion lanes so topology augments the recall-preserving ANN and lexical candidate pool through one product path.
* refactor(bench): prune superseded search lanes
Measure the topology-plus-ANN product path with stable experiment identity and remove obsolete sidecar and tiered controls.
* docs(search): retire stale experiment notes
Keep the benchmark handoff focused on the topology-plus-ANN product lane and its active decision plans.
* refactor(search): prune dead search surfaces
Remove unused fusion, reranker, policy, and router abstractions.
Bound topology materialization and keep document trace payloads opt-in.
* fix(cli): clear build warnings
* fix(xplan): reject stale run identity
* refactor(search)!: remove legacy query stack
Replace the unused AST/ranker/post-processor surface with focused facet aggregation used by product search.
BREAKING CHANGE: removes query parser, result ranker, search filter, and SearchResults container APIs from yams_search.
* refactor(search): type value stage traces
Remove synthetic ComponentResult markers for embedding and concept stages. Preserve failure and timeout states instead of overwriting them with fake successful results.
* refactor(search): isolate benchmark env overlays
Move test-only search environment parsing behind an injectable internal adapter. Keep all existing overlay keys and tuner pin semantics while restoring SearchEngineBuilder to composition.
* refactor(search): unify topology routing options
Snapshot topology policy once at the assist boundary and pass it through routing sessions and diagnostics. Remove repeated scalar copying without changing routing behavior or metric keys.
* fix(search): unify tuner config ownership
Use one complete config-to-params overlay for runtime seeding and no-tuner policy resolution. Reseed attached tuners on setConfig so reported and executed configuration cannot diverge.
* fix(search): snapshot tuner state per query
Read tuned config, params, and state under one lock before routing. Add a TSAN correlation test so adaptive observation cannot produce a torn logical query snapshot.
* fix(search): enforce topology routing contract
Generated configs must preserve hybrid-assist shadow routing, while daemon-backed search must abstain when published topology artifacts are stale. Keep standalone validation and global ANN recall intact.
* fix(daemon): let SQLite reclaim its file
Directly resizing a live database from sampled page counts can truncate pages allocated by concurrent writers. VACUUM must remain the only file-reclamation mechanism.
* fix(metadata): tolerate missing symbol FTS
Readiness lookups can race an unavailable optional FTS migration. Retain the indexed fast path, but retry against the base table when prepare or cached-statement execution proves the capability absent.
* build(fuzz): drop removed query parser target
The optional AFL build still referenced the deleted legacy query parser API and could no longer compile.
* fix(bench): include writes in drain oracle
A zero post-ingest queue is not durable drain while coordinated writes remain queued or in flight.
* fix(daemon): vacuum padded WAL databases safely
161 lines
6.8 KiB
Lean4
161 lines
6.8 KiB
Lean4
/-
|
|
End-to-end system contracts for the YAMS search engine.
|
|
|
|
These contracts connect storage, pipeline, topology artifacts, and search. They
|
|
are intentionally boundary-oriented: theorems protect candidate provenance and
|
|
publication safety while benchmarks decide quality/performance.
|
|
-/
|
|
|
|
import Yams.Core
|
|
import Yams.Topology.Artifacts
|
|
import Yams.Topology.Contracts
|
|
import Yams.Topology.Pipeline
|
|
import Yams.Topology.Storage
|
|
import Yams.Topology.SearchEngine
|
|
import Yams.Topology.TopologyInfluence
|
|
import Yams.Topology.Bridge
|
|
|
|
namespace Yams.Topology.SystemContract
|
|
|
|
/-- System state: the complete state of all modeled subsystems. -/
|
|
structure SystemState where
|
|
storeState : Yams.Storage.StoreState
|
|
pipelineStates : List Yams.Pipeline.DocumentState
|
|
topologyBatch : Yams.Topology.TopologyArtifactBatch
|
|
searchConfig : Yams.SearchEngine.SearchConfig
|
|
deriving Repr, BEq
|
|
|
|
/-- System input: a batch of documents to be ingested. -/
|
|
structure SystemInput where
|
|
docs : List Yams.Storage.StoreDoc
|
|
deriving Repr, BEq
|
|
|
|
/-- System output: search results and topology-route observability. -/
|
|
structure SystemOutput where
|
|
searchResponse : Yams.SearchEngine.SearchResponse
|
|
topologyObservation : Yams.SearchEngine.TopologyRouteObservation
|
|
deriving Repr, BEq
|
|
|
|
/-- End-to-end contract: storage/pipeline/search/topology provenance. -/
|
|
def FullSystemContract
|
|
(input : SystemInput)
|
|
(_before after : SystemState)
|
|
(output : SystemOutput) : Prop :=
|
|
Yams.Storage.PublishedSafe after.storeState ∧
|
|
(∀ doc ∈ input.docs,
|
|
∃ s ∈ after.pipelineStates,
|
|
s.documentId = doc.contentHash ∧ s.stored = true) ∧
|
|
(∀ r ∈ output.searchResponse.results,
|
|
r.doc ∈ after.storeState.metadataVisible) ∧
|
|
Yams.Topology.WellFormedBatch after.topologyBatch ∧
|
|
(∀ s ∈ after.pipelineStates,
|
|
∃ doc ∈ input.docs, s.documentId = doc.contentHash)
|
|
|
|
/-- Weaker contract: just storage-to-search connectivity. -/
|
|
def StorageToSearchContract
|
|
(input : SystemInput)
|
|
(_before after : SystemState)
|
|
(output : SystemOutput) : Prop :=
|
|
Yams.Storage.PublishedSafe after.storeState ∧
|
|
(∀ doc ∈ input.docs, doc.contentHash ∈ after.storeState.metadataVisible) ∧
|
|
(∀ r ∈ output.searchResponse.results, r.doc ∈ after.storeState.metadataVisible)
|
|
|
|
/-- Topology-assisted search contract. -/
|
|
def TopologyAssistedSearchContract
|
|
(input : SystemInput)
|
|
(before after : SystemState)
|
|
(topologyCfg : Yams.SearchEngine.TopologyInfluenceConfig)
|
|
(topologyClusters : List Yams.SearchEngine.TopologyCluster)
|
|
(output : SystemOutput) : Prop :=
|
|
StorageToSearchContract input before after output ∧
|
|
(∀ tc ∈ topologyClusters,
|
|
∃ c ∈ after.topologyBatch.clusters, c.clusterId = tc.id) ∧
|
|
(∀ tc ∈ topologyClusters, ∀ doc ∈ tc.docs,
|
|
doc ∈ after.storeState.metadataVisible) ∧
|
|
(∀ c ∈ Yams.SearchEngine.topologyCandidates topologyCfg true topologyClusters,
|
|
∃ tc ∈ topologyClusters, c.doc ∈ tc.docs)
|
|
|
|
/-- Batched commit preserves publication safety and makes input docs visible. -/
|
|
theorem batchedCommit_preservesStorageToSearch
|
|
(input : SystemInput)
|
|
(state : Yams.Storage.StoreState)
|
|
(hSafe : Yams.Storage.PublishedSafe state) :
|
|
Yams.Storage.PublishedSafe (Yams.Storage.batchedCommit input.docs state) ∧
|
|
(∀ doc ∈ input.docs,
|
|
doc.contentHash ∈ (Yams.Storage.batchedCommit input.docs state).metadataVisible) := by
|
|
constructor
|
|
· exact Yams.Storage.batchedCommit_publishedSafe input.docs state hSafe
|
|
· intro doc hDoc
|
|
simp [Yams.Storage.batchedCommit, Yams.Storage.publishMetadata,
|
|
Yams.Storage.commitRefs, Yams.Storage.prepareDurableDocs, Yams.Storage.hashes]
|
|
exact Or.inr ⟨doc, hDoc, rfl⟩
|
|
|
|
/-- Pipeline completion implies searchability for enabled text/vector sources. -/
|
|
theorem pipelineCompletion_impliesSourceSearchability
|
|
(cfg : Yams.Pipeline.PipelineConfig)
|
|
(before after : Yams.Pipeline.DocumentState)
|
|
(hCompletion : Yams.Pipeline.PipelineCompletionContract cfg before after)
|
|
(hStored : before.stored = true) :
|
|
(cfg.textExtraction = true ∧ cfg.contentIndex = true →
|
|
∃ c, Yams.Topology.Bridge.keywordSearchableToCandidate after.documentId after = some c) ∧
|
|
(cfg.textExtraction = true ∧ cfg.embeddings = true →
|
|
∃ c, Yams.Topology.Bridge.semanticSearchableToCandidate after.documentId after = some c) := by
|
|
constructor
|
|
· intro hKeyword
|
|
exact Yams.Topology.Bridge.completionContract_implies_textCandidate cfg before after
|
|
hCompletion hStored hKeyword.1 hKeyword.2
|
|
· intro hSemantic
|
|
exact Yams.Topology.Bridge.completionContract_implies_vectorCandidate cfg before after
|
|
hCompletion hStored hSemantic.1 hSemantic.2
|
|
|
|
/-- Well-formed topology batch implies valid cluster memberships. -/
|
|
theorem wellFormedBatch_impliesValidMemberships
|
|
(batch : Yams.Topology.TopologyArtifactBatch)
|
|
(hWellFormed : Yams.Topology.WellFormedBatch batch) :
|
|
∀ c ∈ batch.clusters, ∀ docHash ∈ c.memberDocumentHashes,
|
|
∃ m ∈ batch.memberships, m.documentHash = docHash ∧ m.clusterId = c.clusterId := by
|
|
intro c hc docHash hDoc
|
|
exact hWellFormed.2.2 c hc docHash hDoc
|
|
|
|
/-- Convert ClusterArtifact to the search topology cluster abstraction. -/
|
|
def clusterArtifactToTopologyCluster
|
|
(artifact : Yams.Topology.ClusterArtifact) : Yams.SearchEngine.TopologyCluster :=
|
|
{ id := artifact.clusterId
|
|
docs := artifact.memberDocumentHashes }
|
|
|
|
/-- Cluster artifact conversion preserves IDs. -/
|
|
theorem clusterArtifactToTopologyCluster_preservesId
|
|
(artifact : Yams.Topology.ClusterArtifact) :
|
|
(clusterArtifactToTopologyCluster artifact).id = artifact.clusterId := by
|
|
rfl
|
|
|
|
/-- Cluster artifact conversion preserves member docs. -/
|
|
theorem clusterArtifactToTopologyCluster_preservesDocs
|
|
(artifact : Yams.Topology.ClusterArtifact) :
|
|
(clusterArtifactToTopologyCluster artifact).docs = artifact.memberDocumentHashes := by
|
|
rfl
|
|
|
|
/-- Convert entire batch to topology clusters for search. -/
|
|
def batchToTopologyClusters
|
|
(batch : Yams.Topology.TopologyArtifactBatch) : List Yams.SearchEngine.TopologyCluster :=
|
|
batch.clusters.map clusterArtifactToTopologyCluster
|
|
|
|
/-- Batch conversion preserves all cluster IDs. -/
|
|
theorem batchToTopologyClusters_preservesIds
|
|
(batch : Yams.Topology.TopologyArtifactBatch) :
|
|
(batchToTopologyClusters batch).map (fun c => c.id) =
|
|
batch.clusters.map (fun c => c.clusterId) := by
|
|
simp [batchToTopologyClusters, clusterArtifactToTopologyCluster]
|
|
|
|
/-- End-to-end document traceability theorem. -/
|
|
theorem endToEnd_documentTraceability
|
|
(input : SystemInput)
|
|
(before after : SystemState)
|
|
(output : SystemOutput)
|
|
(hContract : FullSystemContract input before after output) :
|
|
∀ doc ∈ input.docs,
|
|
(∃ s ∈ after.pipelineStates, s.documentId = doc.contentHash ∧ s.stored = true) := by
|
|
intro doc hDoc
|
|
exact hContract.2.1 doc hDoc
|
|
|
|
end Yams.Topology.SystemContract
|