yams/tests/unit/metadata/search_query_helpers_catch2_test.cpp
Trevon 7076e4b283
feat(daemon): shutdown hardening + test helper linkage fixes (#44)
* perf(daemon): coalesce metadata writes

* refactor(metadata): split repository ops

* fix(metadata): harden repository invariants

* feat: test coverage and continued refactor work in metadata code

* fix(graph): handle path-like explore queries

- prefer file path symbol lookup for graph explore\n- sanitize alias FTS queries before MATCH

* fix(daemon): quiesce shutdown background work

- Interrupt pending DB acquires before worker shutdown
- Wait for tracked background coroutines and timers to drain

* fix(daemon): cancel repair work on shutdown

Blocked embed and post-ingest queues could keep salvage and\nstuck-doc repair alive during shutdown. Consume cancellation in\nrepair retry loops and lock the integrated ServiceManager path\nwith regressions so shutdown fails fast instead of drifting.

* perf(metadata): reduce sqlite lock contention

* perf(metadata): flatten batch content retries

* fix(daemon): align shutdown wait budgets

A low shutdown timeout override could expire before ServiceManager\nfinished its 5s+30s WorkCoordinator join path. Share the join\nbudget constants, clamp graceful lifecycle waits to that floor,\nand lock the behavior with a daemon regression.

* perf(metadata): bound feedback write waits

* perf(metadata): prep batch content before tx

* fix(daemon): honor no-embeddings tasks

Post-ingest queue tasks dropped the per-task noEmbeddings flag,\nso focused extraction tests still emitted embed jobs and Windows\nCI exercised extra async paths. Preserve the flag through the bus,\nskip embed dispatch when requested, and wake the extraction poller\nimmediately after successful queueing.

* perf(daemon): batch fallback metadata writes

* feat(perf,docs): optimizations for metadata writes, prompt updates and test improvements

* perf(metadata): flatten insert retries

* fix(metadata): clear CI portability blockers

Use the shared portable ScopedEnvVar in metadata search-query helper tests, add mutators for test reuse, and normalize Statement::bindAll integral dispatch so long long arguments bind consistently across platforms. Add focused regression coverage for the bindAll long long path.

* perf(metadata): batch writes and steady bench

* fix(daemon): skip inactive post-ingest pollers

* perf(metadata): tighten tag and path caches

* perf(metadata): cache small batch upserts

* fix(daemon): harden embedded host teardown

* feat(docs): updating docs policies and language

* perf(metadata): tune doc update retries

* perf(metadata): bound download retries

* perf(metadata): bound download metadata waits

* bench(metadata): scope post-ingest content path

* fix(daemon): export embedded test hooks

* fix(daemon): harden test helper linkage

* fix(build): add missing standard includes
2026-06-08 16:29:44 -04:00

116 lines
3.8 KiB
C++

#include <catch2/catch_test_macros.hpp>
#include <string>
#include <vector>
#include "../../common/test_helpers_catch2.h"
#include "src/metadata/repository/search_query_helpers.hpp"
namespace yams::metadata {
#ifdef YAMS_TESTING
void testingResetSearchQueryHelperCaches();
#endif
} // namespace yams::metadata
namespace {
void resetSearchQueryHelperCaches() {
#ifdef YAMS_TESTING
yams::metadata::testingResetSearchQueryHelperCaches();
#endif
}
} // namespace
TEST_CASE("Search query helpers: parseFts5ModeEnv honors supported values",
"[unit][metadata][fts5][search-query-helpers]") {
using yams::metadata::Fts5QueryMode;
using yams::metadata::parseFts5ModeEnv;
yams::test::ScopedEnvVar env("YAMS_FTS_MODE");
SECTION("unset defaults to smart") {
env.unset();
CHECK((parseFts5ModeEnv() == Fts5QueryMode::Smart));
}
SECTION("simple is case-insensitive") {
env.set("SIMPLE");
CHECK((parseFts5ModeEnv() == Fts5QueryMode::Simple));
}
SECTION("nl shorthand selects natural mode") {
env.set("nl");
CHECK((parseFts5ModeEnv() == Fts5QueryMode::Natural));
}
SECTION("natural selects natural mode") {
env.set("natural");
CHECK((parseFts5ModeEnv() == Fts5QueryMode::Natural));
}
SECTION("unknown values fall back to smart") {
env.set("surprising-value");
CHECK((parseFts5ModeEnv() == Fts5QueryMode::Smart));
}
}
TEST_CASE("Search query helpers: includeSearchSnippets caches env-derived behavior",
"[unit][metadata][fts5][search-query-helpers]") {
using yams::metadata::includeSearchSnippets;
yams::test::ScopedEnvVar env("YAMS_SEARCH_INCLUDE_SNIPPET");
SECTION("unset defaults to disabled") {
env.unset();
resetSearchQueryHelperCaches();
CHECK_FALSE((includeSearchSnippets()));
}
SECTION("recognized falsey values disable snippets") {
for (const char* value : {"0", "false", "off", "no"}) {
env.set(value);
resetSearchQueryHelperCaches();
INFO(value);
CHECK_FALSE((includeSearchSnippets()));
}
}
SECTION("non-empty truthy values enable snippets") {
for (const char* value : {"1", "true", "yes", "debug"}) {
env.set(value);
resetSearchQueryHelperCaches();
INFO(value);
CHECK((includeSearchSnippets()));
}
}
}
TEST_CASE("Search query helpers: buildDiagnosticAltOrQuery strips punctuation and limits terms",
"[unit][metadata][fts5][search-query-helpers]") {
using yams::metadata::buildDiagnosticAltOrQuery;
SECTION("empty input yields empty query") {
CHECK((buildDiagnosticAltOrQuery({}).empty()));
}
SECTION("filters short terms and quotes normalized tokens") {
const std::vector<std::string> tokens = {"a", "the", "alpha,", "(beta)", "gamma.",
"delta", "epsilon", "zeta", "eta"};
CHECK((buildDiagnosticAltOrQuery(tokens) ==
"\"alpha\" OR \"beta\" OR \"gamma\" OR \"delta\" OR \"epsilon\""));
}
}
TEST_CASE("Search query helpers: hasAdvancedFts5Operators distinguishes power-user syntax",
"[unit][metadata][fts5][search-query-helpers]") {
using yams::metadata::hasAdvancedFts5Operators;
CHECK((hasAdvancedFts5Operators("title:hello")));
CHECK((hasAdvancedFts5Operators("hello NEAR/3 world")));
CHECK((hasAdvancedFts5Operators("\"exact phrase\"")));
CHECK((hasAdvancedFts5Operators("(foo OR bar) NOT baz")));
CHECK_FALSE((hasAdvancedFts5Operators("dendritic cells (DCs)")));
CHECK_FALSE((hasAdvancedFts5Operators("path:/tmp/file.txt")));
CHECK_FALSE((hasAdvancedFts5Operators("hello and world")));
CHECK_FALSE((hasAdvancedFts5Operators("plain terms only")));
}