Commit graph

1 commit

Author SHA1 Message Date
trvon
4664ae4458
Detection: unify the two repeat-aggregation sinks + IOC severity resolution
Some checks failed
Build and Test / build (debug, clang) (push) Has been cancelled
Build and Test / build (debug, gcc) (push) Has been cancelled
Build and Test / build (release, clang) (push) Has been cancelled
Build and Test / build (release, gcc) (push) Has been cancelled
Build and Test / macos (push) Has been cancelled
Build and Test / docker (push) Has been cancelled
The scan path (handle_process) and the exec-guard recording path
(record_exec_decision) had grown two near-identical repeat-aggregation maps
(repeats_ / exec_repeats_) plus three copies of the IOC-feed severity idiom.
Refactor to one implementation; no behavior change (the existing aggregation and
IOC-severity tests are the oracle and pass unchanged).

- New include/strawberry/repeat_aggregator.hpp: RepeatAggregator owns the
  per-key window map, the 20-full-then-summary cadence and the aggregated count;
  observe(key, now, seen_ns, pid) returns {full, at_threshold, aggregated,
  emit_summary, notify, state}. Each caller keeps its own key, summary-id prefix,
  summary shape and notify behaviour. Both pipeline sinks now hold one instance
  (scan notifies at most hourly; exec passes notify_ns=0). status
  repeats_aggregated sums both totals (atomic, lock-free read).
- ioc_hit_severity(feed): one source for the three IOC match sites (scan_image,
  assess_exec, handle_process) that was the policy_->ioc_feed_severity ternary.
- Leaves the latency-critical assess_exec/decide path untouched; both sinks still
  run under mutex_, off the FAN response.

Unit test tests/test_repeat_aggregator.cpp (window reset, threshold, summary and
notify cadence, per-key independence). Suite 51/51; clang static analyzer and
clang-tidy clean on detection_pipeline.cpp; fold's 7 int-overflow are the accepted
monotonic-timestamp FP class (unchanged by the move); perf-kpi PASS, no regression
(exec_decision p50 unchanged, exec_assess/db_commit within noise or faster).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-10-28 17:39:48 -06:00