Commit graph

3 commits

Author SHA1 Message Date
trvon
be237d6040
Findings: reconcile evidence and harden policy rebuilds
Preserve independent support, typed rule namespaces and stable process lifetimes. Share authoritative managed-set reconciliation across daemon and offline correlation, load offline policy without seeding/migration, and release resources after shutdown-flush exceptions. Keep retirement history, transaction ownership and fault/allocation regressions; no whole-set crash-atomicity or live acceptance claim.
2026-11-03 06:55:47 -07:00
trvon
72d239dee9
Give hash, rule and lineage findings one stable id each
Some checks failed
Build and Test / build (debug, clang) (push) Has been cancelled
Build and Test / build (debug, gcc) (push) Has been cancelled
Build and Test / build (release, clang) (push) Has been cancelled
Build and Test / build (release, gcc) (push) Has been cancelled
Build and Test / docker (push) Has been cancelled
Their ids included the member pids (and rules or hashes), so every new
process joining a group created a new finding and left the previous one
behind as a duplicate. The id is now the group key alone: the hash, the
rule name, or the parent process. The finding is updated in place as the
group grows; the pids stay in its metadata and summary.

Findings stored under the old ids stay as they are (one last duplicate
per group after upgrading). The incremental property test now also checks
that add-only runs leave exactly one finding per group.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-26 21:08:17 -06:00
trvon
e746eaa70d
Correlate incrementally: rebuild only the groups that changed
Some checks failed
Build and Test / build (debug, clang) (push) Has been cancelled
Build and Test / build (debug, gcc) (push) Has been cancelled
Build and Test / build (release, clang) (push) Has been cancelled
Build and Test / build (release, gcc) (push) Has been cancelled
Build and Test / docker (push) Has been cancelled
Every finding is a function of one group of indicators (a process, a
parent, a hash or a rule). IncrementalCorrelator keeps group membership
(ids and keys, not indicator contents) and rebuilds only the groups that
new or changed indicators touch. Each pass used to copy every indicator
and rebuild every finding; it now costs about the size of what changed.

- correlation_engine.cpp: the four group loops become per-group
  functions (re-indented; logic unchanged), shared by the full pass and
  the incremental one.
- EvidenceView keeps a bounded change log of written indicator ids
  (resets after clear(), at first use, or past 65536 entries);
  Database::take_indicator_changes / find_indicators expose it, with
  rolled-back writes reported as removed.
- DetectionPipeline holds its lock only to read changes and members and
  to store findings, as before.

Fix found by the oracle test: an indicator naming a process node but no
pid formed a second group for the same process with the same finding id,
and the two findings overwrote each other. The group pid now comes from
the node id when the pid is missing (finding ids are unchanged).

tests/test_correlation_incremental.cpp: random batches of new and updated
indicators give exactly the findings the full pass after every batch
stored (I1, I2); a batch touching one process rebuilds only its groups
(I3); the store's change log, including a rolled-back write.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-26 19:51:57 -06:00