The HighContrast theme is part of the gnome-themes-standard [0] package
, which is not always available.
Instead of just setting the theme by code, now we distribute the icons.
This ensures that the icons are always clearly visible when using a
qt-material dark theme.
For qt-material light themes and system themes, we'll use the system
icons.
[0] https://download.gnome.org/sources/gnome-themes-standard/
By default we use the system icons theme in the GUI.
The Desktop Environment usually is responsible of switching between
dark and light styles.
However if the user selected a qt-material dark theme from the
Preferences, the icons were not updated, and sometimes they were
practically invisible.
Now if the user selects a qt-material dark theme, we set the
HighContrast icon theme, which ensures that all icons are visible
against dark backgrounds.
Allow to select English language from the Preferences.
This is a static entry like "System default".
It will not load a QTranslator object, so the GUI will use the strings
defined in the code, which are in English.
Closes: #1342
Modify the `_cb_notification_callback` method to properly process notifications that are wrapped in a dictionary to ensure consistent handling regardless of how they're sent from different
parts of the codebase.
discard current selection:
- if the user right clicked on a row not part of a selection.
- if the user clicked on a row, and there's only one row selected.
- if the user clicked on a row already selected.
In PyQt < 5.15 isRowSelected() requires two arguments (row and parent).
Since 5.15, the parent argument is optional, and the default value is an
empty QModelIndex().
In order to support old PyQt versions (Ubuntu 20.x), we add always
the second argument.
- Misc: headers reorganization.
In some DEs, like Enlightenment, some builtins icons may be empty.
The icon is not Null, but there're no available sizes, and the
pixmap is empty.
For now we'll use SP_FileIcon as the default icon, which exists
in this scenario, but we should create a new default icon, and
distribute it with the GUI.
- Pressing the Space key on a view paginates the view forward.
- Apply rule actions both to visible selections (the ones the user
sees), and non-visible selections (those out of the viewport).
- Right clicking on a selection does not discard the selection.
- Left clicking on a selection discards the selection and selects the
clicked row.
- Left clicking on a selected row selects/deselects the row.
ref: #1291
- Fixed the use of Ctrl + mouse dragging to select/deselect rows of
an existing selection.
- Misc: fixed var name, removed unused code, avoid adding non valid
rows to the selection.
ref: #1291
Previously while scrolling, only one row remained selected, and using
the mouse to select rows didn't work.
Now:
- All selected rows remain selected while scrolling.
- The mouse can be used to select rows.
Previous functionality has not chaged:
- Selecting a row toggles the selection.
- ESC discard the selection.
- CTRL + key up/down or click selects/deselects rows.
- CTRL+c copies selected rows to the clipboard.
ref: #1291
- Removed hardcoded sizes for buttons.
- Buttons horizontal layout adjusted to properly show the countdown
(#1274).
Note:
'Maximum' vertical policy does not seem to work with qt-material
and QToolButton, the button height is resized to 0. 'Preferred' seems
to work as expected.
The GUI and daemon versions are displayed in 2 different locations:
- ui: in the title of the main window.
- daemon: in the lower right corner.
Now instead of showing the daemon version as "Version: x.y.z", we
show "Daemon version: x.y.z".
Closes: #1278
We were not matching the end of the domain, which could lead to allow
more domains than expected.
kudos to @FWDekker for reporting this issue.
Closes: #1264
When saving the preferences, we check if the user changed the address of
the node. Usually the current node address is the same than the one
loaded, but some gRPC versions does not report it, so we use
"unix:/local" as the address of the node.
As this address is different than the one configured, we were displaying
unnecessary restart messages to the users.