* Improve name of github CI Go build.
* Unify debian build rules to build both binary debs from same rule set
Added missing build dependency for qttools5-dev-tools.
Note, the install of bpf module is removed because its build rules are not
currently used. This should be fixed.
The build fail because the build uses go build rules and not the
makefile, and thus the protocol files are not generated in the correct
location.
Added github CI build test for Debian package. Note, this build include a
workaround for the lack of upstream tarball. Might be better to create
a tarball from the current source directory first, but then debian/changelog
need to be updated with a version entry for this tarball too.
* Bring Debian package installation more in line with general practice
Bo need to use pip for installing packages, the packages needed are
in Debian Bookworm and Sid. Drop debconf question regarding this and the
dependency on pip.
Stop writing in users home directory, activate autorun using
/etc/xdg/autorun/ instead.
Up until now we detected automatically if a rule was a regular
expression. But if the path or cmdline of a process had certain
characters (backslash), it was not easy to autodetect it, because the
backslash in particular is sent and received encoded (\\).
With this change the user will have to mark manually if the
path/cmdline of a process is a regular expression or no.
Closes#706
When loading and setting the query limit configured, it was causing to
fire an unwanted combobox event, resulting in a DB query without limits,
which in turns with a lot of events was causing slowdowns when displaying
the events window.
On light themes, the systray icon was barely visible. With the new
icons:
- on dark themes should be pretty similar to what we already had.
- on light themes they are much more distinguishables now.
Closes: #643, #339
- Improved user experience, by remembering rows selection when going
back from a detail view. Fixes#620.
- Fixed Users' view query (it didn't list user's connections
correctly and it wasn't efficient).
Restore rules' columns properly after:
- double clicking on the Rules column of the main tab -> and then
clicking on the back button.
- clicking on the Temporary/Permanent items of the Rules tab.
- clicking on a Rule and going back again to the list of rules.
Misc:
- Disallow double-clicks when entering into a detail view from the
Events tab.
- Removed extra/repeated columns adjusting.
Closes#619
The button to delete events of a view is not displayed on the Nodes or
Rules view. It's only displayed in these views when entering into a
detail view.
Closes#605
In some scenarios, showing a notificatio led to a crash with the error:
Dbus.Error.ServiceUnknown: The name ... was not provided by any .service
files.
If the events were saved to a DB on disk,
there were long delays when opening the events window.
Now the events window loads faster, but the Events view is not as
performant as before. It means that while you're monitoring connections,
the GUI may consume 1-5% of the CPU and ~25% when you apply a filter
(only in that moment).
With the previous approach the CPU usage was close to 0-1% in both
cases, so we need to find a way of not causing long delays while being
performant.
More about this:
https://github.com/evilsocket/opensnitch/issues/566#issuecomment-1014930627
- Use a good quality icon on all dialogs.
- Set the icon off when closing, to let the user know that we're
exiting.
- Decreased time to wait to exit to 5secs.
- setDesktopFileName() is only available since 5.7.
- use pragma quick_check to improve DB loading when events are saved to
disk.
- optimize DB on close.
WIP.
Until now we used Qt's systray notifications. They couldn't be disabled
and didn't integrate well with non-Qt based Desktop Environments. Also
we depended on the system tray availability, which is not always
available (i3, phosh, ...).
Now the user can choose to use Qt's notifications, the system
notification service or disabled them completely.
Pros:
- The notification style is defined by the Desktop Environment.
- Can be configured globally from the system settings.
- In many DEs, the notifications are grouped into a single view. So if
you miss any event, you can go there and check out what happened.
- Now we can display notifications on DEs where we couldn't before.
- It's a standard supported by major DEs.
Cons:
- Sometimes we can't connect to the D-Bus mainloop instance. We need to
investigate it.
TODO:
- Deny/Allow new outgoing connections from the notifications,
replacing the current pop-ups.
Requested here: #468 , #476 and #477 .
Instead of the builtin buttons to increase the value of spin boxes, use
regular buttons. It'll be easier to use on touchable devices.
Note: This feature can also be achieved by customizing SpinBoxes' css
style.
- If sys.exit() fails, force exit after 10s.
- Close db connection on exit.
- When closing the GUI (server), set connected nodes to offline.
The status will be updated when nodes connect again / when the server
is available again.
Otherwise, we may end up with nodes marked as _online_ when in reality
they're not connected.
- Add nodes on the main thread.