Unlocks the x86 family end-to-end and makes the write-loop detector precise enough for statically-linked binaries. x86 SLEIGH: - Vendor Ghidra's x86 language specs (specs/x86, x86:LE:64:default + :32:default); add x86-64/x86 .sla build targets. archSpecFor maps x86/64 + x86/32. - ghidra_lifter: set the x86-64 decode context (longMode/addrsize/opsize) in the raw path, and bound decompiler flow at the function end (0xC3 tail fill) so variable-length x86 does not run away into zero padding. Precise SSA def-use (benefits all arches): - ir::pcode::PcodeOp gains in_def (defining-op index per input); the SSA lifter records real def-use. summarizePointerWrites now resolves the store-address base via def-use instead of a last-write heuristic — essential on x86 where arg registers are reused as scratch (RAX) and sub-registers are written (SIL). - paramIndexOf is arch-aware (AArch64 x0–x7; SysV x86-64 RDI/RSI/RDX/RCX/R8/R9). Precision (the key fix at scale): - A copy bounded by a size *parameter* (memcpy-like `for i<n`) is suppressed: if the loop index is `<`-compared against a pure parameter input, the function is size-bounded and not flagged. baby_bof's decode_base64 bounds on strlen(input) (a computed value, not a param) so it still fires. This cut a statically-linked x86-64 binary from 101 findings (≈100 glibc/libstdc++ FPs) to 1 — the real decode_base64 → 264-byte overflow. Perf + reach: - Cache the pre-pass SSA lift and reuse it in the main pass (re-lifting only the few callers of a write-loop callee that need the injected prototype). - Give whole-binary r2 analysis a generous timeout (FOLD_R2_ANALYSIS_TIMEOUT_MS, default 120s) so large static binaries actually analyze (the 3s per-command watchdog left them with an empty function list). Validated: decode_base64 overflow fires on x86-64 (index_amd64.cgi) and AArch64 (index_nocanary.cgi); AArch64 corpus BOF counts unchanged (3/1/1); x86-64 static FP 101→1. Unit: test_pcode_summary +x86-64 case (9 assertions). meson test 77/77. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
35 lines
1,000 B
XML
35 lines
1,000 B
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
|
|
<!-- Set up x86 16-bit in protected mode -->
|
|
|
|
<processor_spec>
|
|
<properties>
|
|
<property key="useOperandReferenceAnalyzerSwitchTables" value="true"/>
|
|
<property key="useropLibs" value="x86"/>
|
|
</properties>
|
|
<programcounter register="EIP"/>
|
|
<segmented_address space="ram" type="protected"/>
|
|
<segmentop space="ram" userop="segment" farpointer="yes">
|
|
<pcode>
|
|
<input name="base" size="2"/>
|
|
<input name="inner" size="2"/>
|
|
<output name="res" size="4"/>
|
|
<body><![CDATA[
|
|
res = (zext(base) << 16) + zext(inner);
|
|
]]></body>
|
|
</pcode>
|
|
<constresolve>
|
|
<register name="DS"/>
|
|
</constresolve>
|
|
</segmentop>
|
|
<context_data>
|
|
<context_set space="ram">
|
|
<set name="addrsize" val="0"/>
|
|
<set name="opsize" val="0"/>
|
|
<set name="protectedMode" val="1"/>
|
|
</context_set>
|
|
<tracked_set space="ram">
|
|
<set name="DF" val="0"/>
|
|
</tracked_set>
|
|
</context_data>
|
|
</processor_spec>
|