Unlocks the x86 family end-to-end and makes the write-loop detector precise enough for statically-linked binaries. x86 SLEIGH: - Vendor Ghidra's x86 language specs (specs/x86, x86:LE:64:default + :32:default); add x86-64/x86 .sla build targets. archSpecFor maps x86/64 + x86/32. - ghidra_lifter: set the x86-64 decode context (longMode/addrsize/opsize) in the raw path, and bound decompiler flow at the function end (0xC3 tail fill) so variable-length x86 does not run away into zero padding. Precise SSA def-use (benefits all arches): - ir::pcode::PcodeOp gains in_def (defining-op index per input); the SSA lifter records real def-use. summarizePointerWrites now resolves the store-address base via def-use instead of a last-write heuristic — essential on x86 where arg registers are reused as scratch (RAX) and sub-registers are written (SIL). - paramIndexOf is arch-aware (AArch64 x0–x7; SysV x86-64 RDI/RSI/RDX/RCX/R8/R9). Precision (the key fix at scale): - A copy bounded by a size *parameter* (memcpy-like `for i<n`) is suppressed: if the loop index is `<`-compared against a pure parameter input, the function is size-bounded and not flagged. baby_bof's decode_base64 bounds on strlen(input) (a computed value, not a param) so it still fires. This cut a statically-linked x86-64 binary from 101 findings (≈100 glibc/libstdc++ FPs) to 1 — the real decode_base64 → 264-byte overflow. Perf + reach: - Cache the pre-pass SSA lift and reuse it in the main pass (re-lifting only the few callers of a write-loop callee that need the injected prototype). - Give whole-binary r2 analysis a generous timeout (FOLD_R2_ANALYSIS_TIMEOUT_MS, default 120s) so large static binaries actually analyze (the 3s per-command watchdog left them with an empty function list). Validated: decode_base64 overflow fires on x86-64 (index_amd64.cgi) and AArch64 (index_nocanary.cgi); AArch64 corpus BOF counts unchanged (3/1/1); x86-64 static FP 101→1. Unit: test_pcode_summary +x86-64 case (9 assertions). meson test 77/77. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
67 lines
1.3 KiB
Text
67 lines
1.3 KiB
Text
define pcodeop getsec_capabilities;
|
|
define pcodeop getsec_enteraccs;
|
|
define pcodeop getsec_exitac;
|
|
define pcodeop getsec_senter;
|
|
define pcodeop getsec_sexit;
|
|
define pcodeop getsec_parameters_EAX;
|
|
define pcodeop getsec_parameters_EBX;
|
|
define pcodeop getsec_parameters_ECX;
|
|
define pcodeop getsec_smctrl;
|
|
define pcodeop getsec_wakeup;
|
|
define pcodeop getsec_unknown;
|
|
|
|
|
|
:GETSEC is vexMode=0 & byte=0x0f; byte=0x37 {
|
|
|
|
if ( EAX != 0x0 ) goto <leaf_1>;
|
|
EAX = 0;
|
|
if ( EBX != 0x0 ) goto <done>;
|
|
EAX = getsec_capabilities( EBX );
|
|
goto <done>;
|
|
|
|
<leaf_1>
|
|
if ( EAX != 0x2 ) goto <leaf_2>;
|
|
getsec_enteraccs( EBX, ECX );
|
|
goto <done>;
|
|
|
|
<leaf_2>
|
|
if ( EAX != 0x3 ) goto <leaf_3>;
|
|
@ifdef IA64
|
|
getsec_exitac( RBX, EDX );
|
|
@else
|
|
getsec_exitac( EBX, EDX );
|
|
@endif
|
|
goto <done>;
|
|
|
|
<leaf_3>
|
|
if ( EAX != 0x4 ) goto <leaf_4>;
|
|
getsec_senter( EBX, ECX, EDX);
|
|
goto <done>;
|
|
|
|
<leaf_4>
|
|
if ( EAX != 0x5 ) goto <leaf_5>;
|
|
getsec_sexit();
|
|
goto <done>;
|
|
|
|
<leaf_5>
|
|
if ( EAX != 0x6 ) goto <leaf_6>;
|
|
EAX = getsec_parameters_EAX( EBX );
|
|
ECX = getsec_parameters_ECX( EBX );
|
|
EBX = getsec_parameters_EBX( EBX );
|
|
goto <done>;
|
|
|
|
<leaf_6>
|
|
if ( EAX != 0x7 ) goto <leaf_7>;
|
|
getsec_smctrl(EBX);
|
|
goto <done>;
|
|
|
|
<leaf_7>
|
|
if ( EAX != 0x8 ) goto <unknown>;
|
|
getsec_wakeup();
|
|
goto <done>;
|
|
|
|
<unknown>
|
|
getsec_unknown();
|
|
|
|
<done>
|
|
}
|