5152d0c9f7
Foundation for replacing fold's dead/abstract binary encoder with a real
SSA P-Code frontend. Verified root-cause gap: serializeBinaryIR() emits only
data-discovery nodes (sections/strings/imports/exports); the control-flow
BinaryExprKind values (BasicBlock/CallSite/...) are never constructed, so the
Z3-BB encoder's encodable filter is always empty and encodeBinaryBBs never
runs — hence 0 binary Z3 findings. The P-Code pipeline supersedes that path.
Phase 0 — docs/internal/ghidra-pcode-integration-research.md: P-Code opcode
core, the decompiler C++ embedding API (LoadImage/SleighArchitecture/Funcdata),
the CORE+DECCORE+SLEIGH source sets, no-bison finding, and pypcode as build
reference.
Phase 1 — vendored Ghidra decompiler at pinned commit (Ghidra_12.1_build,
7e89d94e34...) under third_party/ghidra-decompiler/ (cpp + AArch64 specs +
Apache-2.0 LICENSE + VENDOR.md + .gitignore for build artifacts). Validated by
hand on this clang-21/macOS toolchain:
- full SSA engine (CORE+DECCORE+SLEIGH, 80 files incl. heritage/funcdata/
action) compiles clean, -std=c++11 -O2, NO BFD, NO bison (generated
parsers are committed upstream; ruleparse isn't in the lib set);
- sleigh compiler builds; AArch64 .slaspec -> .sla compiles;
- tools/pcode_dump.cpp (custom LoadImage, no BFD) lifts the real arm64
sym._div_by_zero_direct to correct P-Code: `mov w9,#0 -> COPY(const 0)`,
`sdiv -> INT_SDIV(w8,w9)` — divisor zero-ness explicit in the data flow,
so the Phase-3 encoder proves div-by-zero trivially, multi-arch.
Not yet meson-wired (next step) and no fold-side IR/encoder yet (Phase 2-3);
this commit is the validated vendor + smoke tool.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
57 lines
2.5 KiB
C++
57 lines
2.5 KiB
C++
/* ###
|
|
* IP: GHIDRA
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
/// \file comment_ghidra.hh
|
|
/// \brief Obtain comments by talking to a Ghidra client
|
|
#ifndef __COMMENT_GHIDRA_HH__
|
|
#define __COMMENT_GHIDRA_HH__
|
|
|
|
#include "comment.hh"
|
|
#include "ghidra_arch.hh"
|
|
|
|
namespace ghidra {
|
|
|
|
/// \brief An implementation of CommentDatabase backed by a Ghidra client
|
|
///
|
|
/// Comment information about particular functions is obtained by querying
|
|
/// a Ghidra client. All comments for a single function are queried at once, and
|
|
/// results are cached in this object. The cache needs to be cleared between
|
|
/// functions using the clear() method.
|
|
class CommentDatabaseGhidra : public CommentDatabase {
|
|
ArchitectureGhidra *ghidra; ///< The Architecture and connection to the Ghidra client
|
|
mutable CommentDatabaseInternal cache; ///< A cache of Comment objects received from the Ghidra client
|
|
mutable bool cachefilled; ///< Set to \b true if comments for the current function have been fetched
|
|
void fillCache(const Address &fad) const; ///< Fetch comments for the given function
|
|
public:
|
|
CommentDatabaseGhidra(ArchitectureGhidra *g); ///< Constructor
|
|
virtual void clear(void) { cache.clear(); cachefilled=false; }
|
|
virtual void clearType(const Address &fad,uint4 tp) {
|
|
cache.clearType(fad,tp);
|
|
}
|
|
virtual void addComment(uint4 tp,const Address &fad,
|
|
const Address &ad,const string &txt);
|
|
virtual bool addCommentNoDuplicate(uint4 tp,const Address &fad,const Address &ad,const string &txt);
|
|
virtual void deleteComment(Comment *com) {
|
|
throw LowlevelError("deleteComment unimplemented"); }
|
|
virtual CommentSet::const_iterator beginComment(const Address &fad) const;
|
|
virtual CommentSet::const_iterator endComment(const Address &fad) const;
|
|
virtual void encode(Encoder &encoder) const {
|
|
throw LowlevelError("commentdb::encode unimplemented"); }
|
|
virtual void decode(Decoder &decoder) {
|
|
throw LowlevelError("CommentDatabaseGhidra::decode unimplemented"); }
|
|
};
|
|
|
|
} // End namespace ghidra
|
|
#endif
|