f4f1d55ce1
Iteration 2 of the fold optimization loop (docs/research/optimization-loop-2026-07-30.md). The disposition baselines predated source edits; finding IDs encode location, so line moves surfaced as new+resolved pairs and both project evaluations gated red: - fold: 8 new findings exceeded limit 0 (review coverage 0.111) - yams: 3 new findings exceeded limit 0 Each finding was verified against source before re-baselining: - fold: 5 SafetyObserver virtual-stub clones (line-moved, same methods) accepted-risk; 2 detector-internal clone sites re-hashed, accepted-risk; 2 sql-injection sites re-verified — all SQL text is compile-time constants or fixed internal table lists (store.cpp:22, :251) — false-positive - yams: 3 clone IDs refreshed after line moves (document_metadata.h 600/623, connection_pool.cpp 42); 4 high-complexity locations updated Also fixes the disposition target fingerprint to the exact runner-reproduced configuration fingerprint (manifest_configuration + SOURCE_SETTING_FLAGS defaults), which the prior fold baseline had stale. Green proof (tests/benchmarks/runs/optimization-2026-07-31-dispositions/): fold eval status failed -> ok, yams failed -> ok; finding fingerprints unchanged (fold 0fec78e5..., yams 247523c5...); churn 0, pairwise Jaccard 1.0, review_coverage 1.0. No gate weakened and no production code change.
84 lines
3.6 KiB
JSON
84 lines
3.6 KiB
JSON
{
|
|
"schema_version": 1,
|
|
"target_name": "yams",
|
|
"reviewed_at": "2026-07-31T02:15:00Z",
|
|
"reviewer": "opencode-optimization-loop (fold optimization workflow iteration 2; re-baselined after line drift; each finding verified against source)",
|
|
"target": {
|
|
"revision": "4d942793534b7b13a1fedcc8d017d98dbe18e72f",
|
|
"tu_set_fingerprint": "869d21aa24cad532703390cc2865c1101a96b2aae394169e1ab5a8b126790ec7",
|
|
"configuration_fingerprint": "aca0fdc9e3174bd3b2ef30a3f5a605c0b78b490a1474e6d4cb938887ef3b20c4"
|
|
},
|
|
"notes": "Re-baselined 2026-07-31: 3 clone finding IDs drifted (line moves in document_metadata.h and connection_pool.cpp, verified same code as prior review); 4 high-complexity findings persist with updated locations. Prior review by GitHub Copilot (Fold/Yams source review) 2026-07-31T16:05:20Z.",
|
|
"findings": [
|
|
{
|
|
"id": "clone:literal-insensitive:12245276909989417956:1098403681163497475",
|
|
"rule_id": "fold.clone",
|
|
"status": "accepted-risk",
|
|
"rationale": "MetadataValueTypeUtils::toStringView/toString pair in document_metadata.h; intentional companion helpers, same pattern previously reviewed as accepted-risk. Line moved 601 -> 600 by comment drift.",
|
|
"location": {
|
|
"uri": "../../include/yams/metadata/document_metadata.h",
|
|
"line": 600
|
|
}
|
|
},
|
|
{
|
|
"id": "clone:literal-insensitive:16723759724016722089:6955619696511760552",
|
|
"rule_id": "fold.clone",
|
|
"status": "accepted-risk",
|
|
"rationale": "MetadataValueTypeUtils::fromString switch block; same reviewed accepted-risk pattern, clone-hash inputs shifted by comment drift (was line 578).",
|
|
"location": {
|
|
"uri": "../../include/yams/metadata/document_metadata.h",
|
|
"line": 623
|
|
}
|
|
},
|
|
{
|
|
"id": "clone:literal-insensitive:14923149845992407203:11191373491611600626",
|
|
"rule_id": "fold.clone",
|
|
"status": "actionable",
|
|
"rationale": "Connection-pool trace helper pattern in connection_pool.cpp (db_lifetime_trace_enabled/trace_pool_lifetime area); same finding previously reviewed as actionable at line 54, now at line 42 after comment drift. Actionable debt retained, not new.",
|
|
"location": {
|
|
"uri": "../../src/metadata/connection_pool.cpp",
|
|
"line": 42
|
|
}
|
|
},
|
|
{
|
|
"id": "high-complexity:6758362663857118858",
|
|
"rule_id": "fold.high-complexity",
|
|
"status": "accepted-risk",
|
|
"rationale": "Unchanged persisting finding (types.h complex declaration); reviewed previously.",
|
|
"location": {
|
|
"uri": "../../include/yams/core/types.h",
|
|
"line": 66
|
|
}
|
|
},
|
|
{
|
|
"id": "high-complexity:6222159599337819923",
|
|
"rule_id": "fold.high-complexity",
|
|
"status": "actionable",
|
|
"rationale": "Unchanged persisting actionable finding; line moved 1138 -> 1145 by comment drift.",
|
|
"location": {
|
|
"uri": "../../include/yams/metadata/metadata_repository.h",
|
|
"line": 1145
|
|
}
|
|
},
|
|
{
|
|
"id": "high-complexity:6282006980449136522",
|
|
"rule_id": "fold.high-complexity",
|
|
"status": "actionable",
|
|
"rationale": "Unchanged persisting actionable finding; line moved 290 -> 271 by comment drift.",
|
|
"location": {
|
|
"uri": "../../src/metadata/connection_pool.cpp",
|
|
"line": 271
|
|
}
|
|
},
|
|
{
|
|
"id": "high-complexity:12503670573337107444",
|
|
"rule_id": "fold.high-complexity",
|
|
"status": "actionable",
|
|
"rationale": "Unchanged persisting actionable finding; line moved 681 -> 662 by comment drift.",
|
|
"location": {
|
|
"uri": "../../src/metadata/connection_pool.cpp",
|
|
"line": 662
|
|
}
|
|
}
|
|
]
|
|
}
|