fix(sarif): point informationUri at git.trevon.dev #2
2 changed files with 3 additions and 1 deletions
fix(sarif): point informationUri at git.trevon.dev
fold lives only on git.trevon.dev, but every SARIF report advertised https://github.com/trvon/fold as the tool's information URI, so code scanning UIs and SARIF viewers linked readers to a repository fold no longer uses. The driver now points at https://git.trevon.dev/trevon/fold. test_scan_e2e asserts the URI; it failed before this change.
commit
b03c8615ca
|
|
@ -411,7 +411,7 @@ void writeFilteredSarif(std::ostream& out, const std::vector<Finding>& findings,
|
||||||
{
|
{
|
||||||
{"name", "fold"},
|
{"name", "fold"},
|
||||||
{"version", foldVersion()},
|
{"version", foldVersion()},
|
||||||
{"informationUri", "https://github.com/trvon/fold"},
|
{"informationUri", "https://git.trevon.dev/trevon/fold"},
|
||||||
{"properties",
|
{"properties",
|
||||||
{
|
{
|
||||||
{"z3_version", Z3_get_full_version()},
|
{"z3_version", Z3_get_full_version()},
|
||||||
|
|
|
||||||
|
|
@ -101,6 +101,8 @@ TEST_CASE("SARIF keeps stable rule metadata for structural findings", "[sarif]")
|
||||||
const auto& driver = sarif["runs"][0]["tool"]["driver"];
|
const auto& driver = sarif["runs"][0]["tool"]["driver"];
|
||||||
const auto& results = sarif["runs"][0]["results"];
|
const auto& results = sarif["runs"][0]["results"];
|
||||||
|
|
||||||
|
// fold lives only on git.trevon.dev; SARIF consumers follow this link.
|
||||||
|
REQUIRE(driver["informationUri"] == "https://git.trevon.dev/trevon/fold");
|
||||||
REQUIRE(results[0]["ruleId"] == "fold.clone");
|
REQUIRE(results[0]["ruleId"] == "fold.clone");
|
||||||
REQUIRE(results[0]["properties"]["backend"] == "clang");
|
REQUIRE(results[0]["properties"]["backend"] == "clang");
|
||||||
REQUIRE(results[1]["ruleId"] == "fold.high-complexity");
|
REQUIRE(results[1]["ruleId"] == "fold.high-complexity");
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue