trevon/fold
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix audit findings: soundness, coverage reporting, docs, and review follow-ups #1

Merged
trevon merged 18 commits from fix/audit-findings into master 2026-09-25 06:48:08 +00:00
Conversation 0 Commits 18 Files changed 81 +4 -1
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 76bc00f635 - Show all commits

test(fanout): build the failure worker before the recovery tests

Prev Next 
fold:subprocess_fanout reads FOLD_TEST_FANOUT_FAILURE_WORKER, but the
worker target is build_by_default: false and the test declared
`depends: []`, so a plain `meson test -C build/release` ran the two
recovery cases against a binary that was never built and failed both
(`REQUIRE(std::filesystem::exists(helper))`). The test now depends on
the worker, and the suite is green from a fresh build.
trvon 2026-09-24 20:00:17 -06:00
commit 76bc00f635
Signed by: trevon
GPG key ID: 38686EA797D7A8A7

5
tests/integration/meson.build
View file

@ -44,7 +44,10 @@ test_subprocess_fanout = executable(
# fan-out can spawn it.
fold_bin = meson.project_build_root() / 'src' / 'cli' / 'fold'
test('subprocess_fanout', test_subprocess_fanout,
depends: [], # fold executable target lives in src/cli — referenced via path
# fold lives in src/cli and is referenced via path. The failure worker is
# build_by_default: false, so without this dependency `meson test` ran the
# recovery cases against a helper that was never built and failed them.
depends: [fanout_failure_worker],
env: {
'FOLD_FIXTURES_DIR': join_paths(meson.current_source_dir(), '..', 'fixtures'),
'FOLD_WORKER_BINARY': fold_bin,